Skip to content

feat(fiori-mcp-server) how to add extensions to odata v4 fiori elements#4552

Open
devinea wants to merge 10 commits intomainfrom
mcp_docs_extension_content
Open

feat(fiori-mcp-server) how to add extensions to odata v4 fiori elements#4552
devinea wants to merge 10 commits intomainfrom
mcp_docs_extension_content

Conversation

@devinea
Copy link
Copy Markdown
Member

@devinea devinea commented Apr 16, 2026 •
edited
Loading

feat(fiori-mcp-server) how to add extensions to odata v4 fiori elements

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: e28d2ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/fiori-docs-embeddings Patch
@sap-ux/fiori-mcp-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devinea devinea force-pushed the mcp_docs_extension_content branch from b11f00f to 4095d79 Compare April 16, 2026 02:13
vinayhospete
vinayhospete approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vinayhospete vinayhospete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@devinea devinea marked this pull request as ready for review April 30, 2026 13:45
@devinea devinea requested a review from a team as a code owner April 30, 2026 13:45
@hyperspace-insights
Copy link
Copy Markdown
Contributor

hyperspace-insights Bot commented Apr 30, 2026

Summary

The following content is AI-generated and provides a summary of the pull request:

Add Fiori Elements OData V4 Extension Patterns Documentation

New Features

✨ Adds comprehensive developer documentation for implementing extensions in SAP Fiori Elements OData V4 applications, covering verified working patterns and known broken patterns with detailed pitfall explanations.

Changes

  • .changeset/tough-cows-smell.md: Adds a patch-level changeset entry for the @sap-ux/fiori-docs-embeddings package documenting the new content.

  • packages/fiori-docs-embeddings/data_local/fiori_extension_instructions.md: Adds a detailed reference guide covering four major Fiori Elements V4 extension scenarios:

    • Custom Column Link → Read-Only Popup (✅ Verified Working): Step-by-step guide using sap.ui.layout.form.SimpleForm with OData V4 bindElement to display navigation entity data in a Fragment.load() dialog.
    • Custom Column Popup with macros:Form (⚠️ Not Working): Documented as a reference for error recognition — explains why sap.fe.macros.Form and sap.fe.macros.FormElement cannot be used in runtime-loaded fragments.
    • Custom Page with Timeline Control (✅ Verified Working): Full walkthrough for adding a sap.suite.ui.commons.Timeline custom FPM page navigated from a List Report toolbar button.
    • Object Page Header Toolbar Data Entry Popup (✅ Verified Working): Pattern for adding a data-entry dialog using sap.m.Input and sap.m.DatePicker bound to a JSON model.

    The document also includes 16 numbered critical pitfalls covering common silent failures, such as incorrect event handler prefixes, broken macros:Form usage at runtime, this.getView() vs this.base.getView() in controller extensions, and correct Fragment.load() Promise patterns.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.20.37

  • File Content Strategy: Full file content
  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.ready_for_review
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Default Template
  • Correlation ID: 1608e832-89bf-4cfe-b519-0f41e04c860f

hyperspace-insights[bot]
hyperspace-insights Bot reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds well-structured SAP Fiori Elements extension documentation to the embeddings data store with a correct patch changeset. The content is thorough and the format is consistent with the existing build-embeddings.ts pipeline expectations.

Two minor documentation quality issues were flagged: (1) the coexistence of ListReportExt.js and ListReportExt.controller.js in the Step 4/4b alternative approach could benefit from an explicit clarification to avoid developer confusion, and (2) the BROKEN pattern section's error list omits the missing null guard on onCloseMergeTravelsPopup, which would be useful for completeness when readers use it for error recognition.

PR Bot Information

Version: 1.20.37

  • File Content Strategy: Full file content
  • Event Trigger: pull_request.ready_for_review
  • LLM: anthropic--claude-4.6-sonnet
  • Agent Instructions:
  • Correlation ID: 1608e832-89bf-4cfe-b519-0f41e04c860f

Comment thread packages/fiori-docs-embeddings/data_local/fiori_extension_instructions.md
Comment thread packages/fiori-docs-embeddings/data_local/fiori_extension_instructions.md
heimwege
heimwege approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc lgtm

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyperspace-insights hyperspace-insights[bot] hyperspace-insights[bot] left review comments

@heimwege heimwege heimwege approved these changes

@vinayhospete vinayhospete vinayhospete approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devinea @heimwege @vinayhospete